Good evening, community!
I've already implied my suggestions for the next version of this awesome script to purehate via PM and received a positive feedback from him telling me that he plans to rework the script as soon as he finds the time and passion to do so. I'd like to put my suggestions for open discussion and refresh this thread due to the fact that I'm so amazed how smooth his script does what it should. Should be the GOLD-STANDARD for BackTrack! Maybe some of you even have some cool ideas how the script could be further enhanced?
Here are mine (feel free to add your suggestions and constructive criticism):
1. A function checking the final wordlist for cleanness would rock. I'm aware of the fact that there's already a function to delete lines matching a specific pattern. But as for merging lists I've collected I'd love to be able to automatically make sure that really NO CRAP is in the final list which might be eating up disk space and cannot be used for WPA/WPA2 pentesting.
2. It occured to me multiple times that I executed the script from a thumbdrive. After about half an hour of processing, the script only spit out the error message that no space was left on the device. The script continued - and the only outcome was a an empty file. Should be clear as the sky to have enough space on the drive beforehand, but I'd consider such a check as a neat addition as well. Say, that upon executing the script, some quick check of the HDD occurs and if the probable size exceeds HDD space, a waring shows up.
3. The command in section "Cleaning up the mess..." should be changed to the following code:
How come? Obviously it takes waay too long to clean up the leftovers with "rm -rf". Although I really don't know how that occurs and what benefits the -rf option should bring, I'm sure other will appreciate the simplification enjoy their wordlist much sooner.
4. In my own slightly modified version, words of the final wordlist are counted right after finishing the whole optimization process.
Something as simple as this shouldn't be a problem to integrate at all:
Now it's your turn to contribute. Shake it!
echo -e "\n$passout should be located in the current directory."
echo "Hold on, I'm counting the words in $passout..."
wc -l $passout
echo "Returning to main menu ......"